Retention period edge case#12421
Open
jo-pol wants to merge 1 commit into
Open
Conversation
- start date off by one - end date: neither check nor report
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
cmbz
added
FY26 Sprint 24
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Jun 29, 2026
stevenwinship
left a comment
stevenwinship
left a comment
Contributor
There was a problem hiding this comment.
Tested with and without this PR. Looks good and fixed the problem
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we need this PR:
When you select a retention period the current date + one year is offered as an option but not allowed. The error message however says it is allowed.
What this PR does:
isBefore(...)into<= ...Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
WEB-UI:
API:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Messages will now look like:
With a date over a thousand years in the future, you will no longer get the web-ui message:
datasetForm:fileRetentionDate: Validation Error: Value must be between 2027-06-01 and 3026-06-01.Is there a release notes update needed for this change?:
Additional documentation: